Modules foundations #669
Merged
Modules foundations #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianmroz
force-pushed
the
feature/modules
branch
from
4fc19ce to
3a0bf8c
Compare
… Only root endpoint refreshes settings (if specific option is set in config)
mkuthan
requested changes
Nov 9, 2020
| @@ -261,7 +261,7 @@ export const SETTINGS_MANAGER = new SettingsManager(settingsStore, { | |||
| if (PRINT_CONFIG) { | |||
| var withComments = Boolean(parsedArgs["with-comments"]); | |||
|
|
|||
| SETTINGS_MANAGER.getSettings({ | |||
| SETTINGS_MANAGER.getFreshSettings({ | |||
There was a problem hiding this comment.
refreshSettings sound like action with some side effect, but this function is still a getter. Honestly I don't like either option.
| } | ||
| return Promise.race([task, timeout(timeoutMs)]) | ||
| .catch(() => { | ||
| this.logger.error("Settings load timeout hit, continuing"); |
There was a problem hiding this comment.
error or warn?
put timeout value in the message, will be more descriptive
|
|
||
| return currentWork.then(() => this.appSettings); | ||
| getSettings(opts: GetSettingsOptions = {}): Promise<AppSettings> { | ||
| return this.handleSettingsTask(this.settingsLoaded, opts); |
There was a problem hiding this comment.
why settingsLoaded is passed as argument if method could access the promise from the object field itself?
There was a problem hiding this comment.
Because in different invocation we pass decorated promise:
mkuthan
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.